Re: [mmc] alternative TI FM MMC/SD driver for 2.6.21-rc7

[Alex Dubov <oakad@yahoo.com>]

> 
> I am not in any way argue that your driver architecture is wrong or that you
> should change anything. My point was simple. [tifm_sd] can only work with
> [tifm_7xx1]. If you add support for let's say [tifm_8xx2] in the future, which
> would have port offsets different that [tifm_7xx1], you would also need a
> completely new modules for slots (sd, ms, etc).
> 

Does not this constitutes an unbounded speculation? And then, what would you propose to do with
adapters that have SD support disabled? There are quite a few of those in the wild, as of right
now (SD support is provided by bundled SDHCI on such systems, if at all). Similar argument goes
for other media types as well - many controllers have xD support disabled too (I think you have
one of those - Sony really values its customers). After all, it is not healthy to have dead code
in the kernel.

On the other hand, if TI puts out a controller which is functionally identical, but has different
register map, it wouldn't be hard to refactor the code. 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/