Re: [PATCH] powerpc pseries rtasd: Convert to kthread API.

On Thu, Apr 19, 2007 at 01:58:46AM -0600, Eric W. Biederman wrote:
> From: Eric W. Biederman <[email protected]>
> 
> This patch modifies the startup of rtasd to use kthread_run instaed of
> a combination of kernel_thread and daemonize.  Making the code a little
> simpler and more maintainble.

Looks okay, but I have some questions about the original code.

Why does the driver only check if it really needs to run in the
thread and calls vmalloc from it?  If we did all these in the
initialization function we could actually properly unwind.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Remaining straight forward kthread API conversions...
    • From: [email protected] (Eric W. Biederman)
  • [PATCH] powerpc pseries rtasd: Convert to kthread API.
    • From: "Eric W. Biederman" <[email protected]>

• Prev by Date: Re: [PATCH] powerpc pseries eeh: Convert to kthread API
• Next by Date: Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
• Previous by thread: [PATCH] powerpc pseries rtasd: Convert to kthread API.
• Next by thread: [PATCH] smbfs: Remove unnecessary allow_signal
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]