Re: [PATCH] reiserfs: fix xattr root locking/refcount bug

On Sat, 21 Apr 2007 11:26:31 -0400 Jeff Mahoney <[email protected]> wrote:

>  The listxattr() and getxattr() operations are only protected by a read
>  lock. As a result, if either of these operations run in parallel, a race
>  condition exists where the xattr_root will end up being cached twice,
>  which results in the leaking of a reference and a BUG() on umount.
> 
>  This patch refactors get_xa_root(), __get_xa_root(), and
>  create_xa_root(), into one get_xa_root() function that takes
>  the appropriate locking around the entire critical section.

Great, thanks.

Now we need to work out the timing.  Our options are to shove
it into 2.6.21 immediately, or to give it a run in 2.6.22-rc1 then
backport into 2.6.21.x.

What is everyone's confidence level?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] reiserfs: fix xattr root locking/refcount bug
    • From: Jeff Mahoney <[email protected]>
  • Re: [PATCH] reiserfs: fix xattr root locking/refcount bug
    • From: Andrea Righi <[email protected]>

• References:
  • Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs
    • From: "Vladimir V. Saveliev" <[email protected]>
  • Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs
    • From: Jeff Mahoney <[email protected]>
  • Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs
    • From: Andrew Morton <[email protected]>
  • Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs
    • From: Jeff Mahoney <[email protected]>
  • Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs
    • From: Andrea Righi <[email protected]>
  • Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs
    • From: Jeff Mahoney <[email protected]>
  • Re: Fwd: Fw: [2.6.20.4] BUG: dentry xattrs still in use in shrink_dcache_for_umount() with reiserfs
    • From: Jeff Mahoney <[email protected]>
  • [PATCH] reiserfs: fix xattr root locking/refcount bug
    • From: Jeff Mahoney <[email protected]>

• Prev by Date: Re: [PATCH -mm] Taskstats fix the structure members alignment issue
• Next by Date: Re: Linux 2.6.20.7 - Hard Disk rumbling?
• Previous by thread: [PATCH] reiserfs: fix xattr root locking/refcount bug
• Next by thread: Re: [PATCH] reiserfs: fix xattr root locking/refcount bug
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]