Re: [patch 2/8] allow unprivileged umount

> > +static bool permit_umount(struct vfsmount *mnt, int flags)
> > +{
> >
> > ...
> >
> > +	return mnt->mnt_uid == current->uid;
> > +}
> 
> Yes, this seems very wrong.  I'd have thought that comparing user_struct*'s
> would get us a heck of a lot closer to being able to support aliasing of
> UIDs between different namespaces.
> 

OK, I'll fix this up.

Actually an earlier version of this patch did use user_struct's but
I'd changed it to uids, because it's simpler.  I didn't think about
this being contrary to the id namespaces thing.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 2/8] allow unprivileged umount
    • From: Andrew Morton <[email protected]>

• References:
  • [patch 0/8] mount ownership and unprivileged mount syscall (v4)
    • From: Miklos Szeredi <[email protected]>
  • [patch 2/8] allow unprivileged umount
    • From: Miklos Szeredi <[email protected]>
  • Re: [patch 2/8] allow unprivileged umount
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [patch 1/8] add user mounts to the kernel
• Next by Date: Re: [patch 7/8] allow unprivileged mounts
• Previous by thread: Re: [patch 2/8] allow unprivileged umount
• Next by thread: Re: [patch 2/8] allow unprivileged umount
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]