Re: [Devel] Re: [PATCH] bluetooth bnep: Convert to kthread API.

[Cedric Le Goater <clg@fr.ibm.com>]

Andrew Morton wrote:
> On Thu, 19 Apr 2007 01:58:51 -0600
> "Eric W. Biederman" <ebiederm@xmission.com> wrote:
> 
>> From: Eric W. Biederman <ebiederm@xmission.com>
>>
>> This patch starts kbenpd using kthread_run replacing
>> a combination of kernel_thread and daemonize.  Making
>> the code a little simpler and more maintainable.
>>
>>
> 
> 	while (!atomic_read(&s->killed)) {
> 
> ho hum.


yes. we need something like :

-       while (!atomic_read(&s->killed)) {
+       while (1) {
                try_to_freeze();
 
                set_current_state(TASK_INTERRUPTIBLE);
 
+               if (atomic_read(&s->killed))
+                       break;
+

I have an old patch for this driver. I'll refresh it.

>> +	task = kthread_run(bnep_session, s, "kbnepd %s", dev->name);
> 
> It's unusual to have a kernel thread which has a space in its name.  That
> could trip up infufficient-defensive userspace tools.

but we can't just change it, can we ? i could be used by a user space tool 
to check if the thread is running.

C.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/