On Thu, 2007-04-19 at 16:37 -0700, Andrew Morton wrote:
> On Thu, 19 Apr 2007 01:58:48 -0600
> "Eric W. Biederman" <[email protected]> wrote:
>
> > Start the g4fand using kthread_run not a combination
> > of kernel_thread and deamonize. This makes the code
> > a little simpler and more maintainable.
>
> I had a bit of trouble reviewing this one because I was laughing so hard at
> the attempted coding-style in that driver. Oh well.
Heh
> I continue creeping into Christoph's camp - there's quite a bit of
> open-coded gunk which would go away if we were to teach this driver about
> kthread_should_stop() and kthread_stop(), and the conversion looks awfully
> easy to do. It's a shame to stop here.
>
> Oh well, I guess at least this is some forward progress.
My main problem with touching that driver is that I don't have the
hardware to test. I'll try to find a user to play the ginea pig.
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
