Re: Loud "pop" coming from hard drive on reboot

> +		if (dev->needs_flush && ata_try_flush_cache(dev)) {
>  			return ata_scsi_flush_xlat;
> +			dev->needs_flush = 0;

Works better if you swap the dev-> and return lines

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Loud "pop" coming from hard drive on reboot
    • From: Mark Lord <[email protected]>

• References:
  • Re: Loud "pop" coming from hard drive on reboot
    • From: Bodo Eggert <[email protected]>
  • Re: Loud "pop" coming from hard drive on reboot
    • From: Tejun Heo <[email protected]>
  • Re: Loud "pop" coming from hard drive on reboot
    • From: Alan Cox <[email protected]>
  • Re: Loud "pop" coming from hard drive on reboot
    • From: Tejun Heo <[email protected]>
  • Re: Loud "pop" coming from hard drive on reboot
    • From: Alan Cox <[email protected]>
  • Re: Loud "pop" coming from hard drive on reboot
    • From: Mark Lord <[email protected]>

• Prev by Date: Re: [PATCH RFD] alternative kobject release wait mechanism
• Next by Date: Re: [Devel] Re: [patch 05/10] add "permit user mounts in new namespace" clone flag
• Previous by thread: Re: Loud "pop" coming from hard drive on reboot
• Next by thread: Re: Loud "pop" coming from hard drive on reboot
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]