Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2)

Dave Hansen wrote:
> On Tue, 2007-04-17 at 19:34 +0400, Pavel Emelianov wrote:
>> +#define SHOW_TOP_SLABS 10 
> 
> Real minor nit on this one: SHOW_TOP_SLABS sounds like a bool.  "Should
> I show the top slabs?"
> 
> This might be a bit more clear:
> 
> #define TOP_NR_SLABS_TO_SHOW 10 
> 
> or
> 
> #define NR_SLABS_TO_SHOW 10

Agree :) Will fix in a moment.

> 
> -- Dave
> 
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] Show slab memory usage on OOM and SysRq-M (v2)
  - From: Pavel Emelianov <[email protected]>
- Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2)
  - From: Dave Hansen <[email protected]>

Prev by Date: Re: [PATCH] libata: add Samsung HD401LJ to the NCQ blacklist
Next by Date: Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]
Previous by thread: Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2)
Next by thread: Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2)
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]