Re: [KJ][PATCH]Rocket port:use mutex instead of binary semaphore

 > -	down_interruptible(&info->write_sem);
 > +	if(mutex_lock_interruptible(&info->write_lock)){
 > +		return -ERESTARTSYS;
 > +	}

1) This is a semantic change.  Of course using down_interruptible()
without checking the return value is almost certainly a bug, but have
you thought about whether returning ERESTARTSYS is correct here?  If
you have, then please include the reasoning in your patch description.
(Another possibility would be to just use an uninterruptible mutex_lock())

2) The coding style for the if statement is not quite right.  The
correct way is to do

	if (condition)
		one_liner;

(note the space between the 'if' and the '(', and no braces used)

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [KJ][PATCH]Rocket port:use mutex instead of binary semaphore
    • From: Milind Arun Choudhary <[email protected]>

• References:
  • [KJ][PATCH]Rocket port:use mutex instead of binary semaphore
    • From: Milind Arun Choudhary <[email protected]>

• Prev by Date: [BUG] aic7xxx/aicasm build failure w/gcc-3.4.6
• Next by Date: PROBLEM: Unable to add subdirectory: Ooops in sys_add_file, called from kobject_register
• Previous by thread: [KJ][PATCH]Rocket port:use mutex instead of binary semaphore
• Next by thread: Re: [KJ][PATCH]Rocket port:use mutex instead of binary semaphore
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]