Re: [PATCH v2] hpet: Enable hidden HPET on NVidia motherboards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 16 Apr 2007, Krzysztof Halasa wrote:

Mikko Tiihonen <[email protected]> writes:

Enables HPET for NVidia motherboards with broken BIOS. The patch reads
the HPET address from the pci config space. The patch should also work
if ACPI is disabled.

The HPET search is done in early-quirks because even
DECLARE_PCI_FIXUP_EARLY was too late. If the new quirk causes problems
it can be disabled with the nohpet boot option.

The patch assumes that the BIOS has done the basic setup of HPET, but
has not published the result in ACPI tables. This is at least true for
some Asus and Gigabyte motherboards.

I think the code should only be enabled by its CONFIG_*.

Currently the all the code is protected by CONFIG_HPET.
Are you proposing to use for example CONFIG_HPET_NVIDIA instead?

I think that the code should be safe even without it's own config option.
It won't override values from ACPI tables and can still be disabled with
nohpet boot option. Also all the code and data are __init.

-Mikko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux