Re: [PATCH] Don't attach callback to a going-away netlink socket

Pavel Emelianov wrote:
> Patrick McHardy wrote:
> 
>>>There is a race between netlink_dump_start() and netlink_release()
>>>that can lead to the situation when a netlink socket with non-zero
>>>callback is freed.
>>
>>
>>Can you describe the race in more detail please?
>>
> 
> Here it is:
> 
> [...]
> The proposal it to make sock_orphan before detaching the callback
> in netlink_release() and to check for the sock to be SOCK_DEAD in
> netlink_dump_start() before setting a new callback.


Thanks, good catch. Your patch also looks good.

Acked-by: Patrick McHardy <[email protected]>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] Don't attach callback to a going-away netlink socket
  - From: Pavel Emelianov <[email protected]>
- Re: [PATCH] Don't attach callback to a going-away netlink socket
  - From: Patrick McHardy <[email protected]>
- Re: [PATCH] Don't attach callback to a going-away netlink socket
  - From: Pavel Emelianov <[email protected]>

Prev by Date: Re: [xfs-masters] Re: mm snapshot broken-out-2007-04-11-02-24.tar.gz uploaded
Next by Date: Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]
Previous by thread: Re: [PATCH] Don't attach callback to a going-away netlink socket
Next by thread: Re: [PATCH] Don't attach callback to a going-away netlink socket
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]