Re: [PATCH 1/4] Pte drop ptep_get_and_clear paravirt op.patch

[Zachary Amsden <zach@vmware.com>]

Jeremy Fitzhardinge wrote:
> Zachary Amsden wrote:
>   
> > In shadow mode hypervisors, ptep_get_and_clear achieves the desired
> > purpose of keeping the shadows in sync by issuing a native_get_and_clear,
> > followed by a call to pte_update, which indicates the PTE has been
> > modified.
> >
> > Direct mode hypervisors (Xen) have no need for this anyway, and will trap
> > the update using writable pagetables.
> >
> > This means no hypervisor makes use of ptep_get_and_clear; there is no
> > reason to have it in the paravirt-ops structure.  Change confusing
> > terminology about raw vs. native functions into consistent use of
> > native_pte_xxx for operations which do not invoke paravirt-ops.
> >   
> >     
>
> Looks OK to me.  Are you going to put this into the pvops queue?
>
> Acked-by: Jeremy Fitzhardinge <jeremy@xensource.com>

Yes, the rest are still undergoing feedback.  I'll kick this in and 
fixup the damage it causes.

Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/