On 04/11, Eric W. Biederman wrote:
>
> @@ -435,8 +436,12 @@ static void __init setup_command_line(char *command_line)
> static void noinline rest_init(void)
> __releases(kernel_lock)
> {
> + int pid;
> kernel_thread(init, NULL, CLONE_FS | CLONE_SIGHAND);
> numa_default_policy();
> +
> + pid = kernel_thread(kthreadd, NULL, CLONE_FS | CLONE_FILES);
> + kthreadd_task = find_task_by_pid(pid);
> unlock_kernel();
Just curious. What if kernel/kthread.c declares
static struct task_struct *kthreadd_task = &init_task;
an then kthreadd_setup() does kthreadd_task = current. I assume it is always
safe to try_to_wake_up(idle_thread), because it always TASK_RUNNING. This
way we don't need to export kthreadd_task.
> + spin_lock(&kthread_create_lock);
> + list_add_tail(&create.list, &kthread_create_list);
> + wake_up_process(kthreadd_task);
> + spin_unlock(&kthread_create_lock);
Very minor nit, but we don't need to do wake_up under spin_unlock().
Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
