Re: [PATCH 7/7] ALPHA: support graphics on non-zero PCI domains

[Jay Estabrook <jay.estabrook@hp.com>]

Richard Henderson wrote:
> On Wed, Apr 11, 2007 at 12:30:48PM +0400, Ivan Kokshaysky wrote:
>   
> > +VGA_MAP_MEM(unsigned long xaddr, unsigned int size)
> > +{
> > +	/* Create a new VGA ioport resource WRT the hose it is on. */
> > +	if (pci_vga_hose && pci_vga_hose->index) {
> > +		static struct resource alpha_vga =
> > +		  { .name = "alpha-vga+", .start = 0x3C0, .end = 0x3DF };
> > +		struct resource new_vga = alpha_vga;
> > +
> > +		new_vga.start += pci_vga_hose->io_space->start;
> > +		new_vga.end   += pci_vga_hose->io_space->start;
> > +		request_resource(&ioport_resource, &new_vga);
> >     
>
> This leaks the local stack frame variable new_vga into the
> resource tree, does it not?  Shouldn't you be kmallocing this?
>
>
> r~
>   
Yes, it does leak, and yes, it should be kmalloced. Something like this?

       struct resource *new_vga;

       new_vga = kmalloc(sizeof(struct resource), GFP_ATOMIC);
       if (new_vga) {
           *new_vga = alpha_vga;
           new_vga->start += pci_vga_hose->io_space->start;
           new_vga->end   += pci_vga_hose->io_space->start;
           request_resource(&ioport_resource, new_vga);
       }

Thanks, Richard, I'll regenerate this one...

--Jay++

--
Jay A Estabrook                            HPTC - XC I & B
Hewlett-Packard Company - ZKO1-3/D-B.8     (603) 884-0301
110 Spit Brook Road, Nashua NH 03062       Jay.Estabrook@hp.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/