From: Andrew Morton <[email protected]>
Date: Tue, 10 Apr 2007 18:47:38 -0700
> On Tue, 10 Apr 2007 18:36:29 -0700 (PDT)
> David Miller <[email protected]> wrote:
>
> > From: Andrew Morton <[email protected]>
> > Date: Tue, 10 Apr 2007 18:29:37 -0700
> >
> > > git-net.patch implements generic lib/div64.c, but s390 also has a
> > > private one. Presumably the appropriate fix is to remove s390's
> > > private implementation within davem's tree.
> >
> > The s390 version seems to be optimized in assembler for that
> > processor, therefore we should probably instead elide the
> > generic version on s390.
>
> We're sure that it has the same API?
Yes, I read over it, I'm pretty sure it does.
> attribute(weak) would give a nicer result?
I'm not so sure.
> We'd also need to remove s390's EXPORT_SYMBOL(__div64_32), so s390 ends up
> using lib/div64.c's EXPORT_SYMBOL().
It shouldn't matter if we use s390's or the generic version's....
Oh, I see, s390 uses lib-y for it's div64.o object, that's a bug.
I'll fix that up, thanks Andrew.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
