Re: [PATCH] Add spaces on either side of case "..." operator.

Andrew Morton wrote:
> #define AUDIT_FIRST_USER_MSG    1100    /* Userspace messages mostly uninteresting to kernel */
> #define AUDIT_USER_AVC          1107    /* We filter this differently */
> #define AUDIT_LAST_USER_MSG     1199
>
> and CPP turns that into
>
>  case 1100 ...1199:
>  case 2100 ...2999:
>
> and it does the same when the comments are stripped from the #defines.
>
> So we were saved by the trailing space which cpp added to the expanded
> macro.  I wonder why cpp did that, and to what extent one can rely cpp
> doing that.

I think its required to.  If it didn't, it would be effectively pasting
two tokens together without the ## operator.  But putting spaces in is
safer - or putting () around the numbers.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Add spaces on either side of case "..." operator.
    • From: Alexey Dobriyan <[email protected]>

• References:
  • [PATCH] Add spaces on either side of case "..." operator.
    • From: "Robert P. J. Day" <[email protected]>
  • Re: [PATCH] Add spaces on either side of case "..." operator.
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] Linux 2.4.x MTD CFI P30/P33 support
• Next by Date: Re: [PATCH] Only send pdeath_signal when getppid changes.
• Previous by thread: Re: [PATCH] Add spaces on either side of case "..." operator.
• Next by thread: Re: [PATCH] Add spaces on either side of case "..." operator.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]