Re: [patch] sched: align rq to cacheline boundary

* Siddha, Suresh B <[email protected]> wrote:

> Align the per cpu runqueue to the cacheline boundary. This will 
> minimize the number of cachelines touched during remote wakeup.

> -static DEFINE_PER_CPU(struct rq, runqueues);
> +static DEFINE_PER_CPU(struct rq, runqueues) ____cacheline_aligned_in_smp;

ouch!! Now how did _that_ slip through. The runqueues had been 
cacheline-aligned for ages. Or at least, they were supposed to be.

could you see any improvement in profiles or workloads with this patch 
applied? (just curious - it's an obviously right fix)

> Signed-off-by: Suresh Siddha <[email protected]>

Acked-by: Ingo Molnar <[email protected]>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] sched: align rq to cacheline boundary
    • From: "Siddha, Suresh B" <[email protected]>

• References:
  • [patch] sched: align rq to cacheline boundary
    • From: "Siddha, Suresh B" <[email protected]>

• Prev by Date: Re: [PATCH 1/2] fs: use memclear_highpage_flush to zero page data
• Next by Date: Re: m68knommu and vmlinux.lds.h RODATA
• Previous by thread: Re: [patch] sched: align rq to cacheline boundary
• Next by thread: Re: [patch] sched: align rq to cacheline boundary
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]