Re: [PATCH 1/10] I386 sysenter arch pages fix.patch

[Jeremy Fitzhardinge <jeremy@goop.org>]

Zachary Amsden wrote:
> In compat mode, the return value here was uninitialized.
>
> Signed-off-by: Zachary Amsden <zach@vmware.com>
>
> diff -r 1fda49a076ed arch/i386/kernel/sysenter.c
> --- a/arch/i386/kernel/sysenter.c	Fri Apr 06 14:25:09 2007 -0700
> +++ b/arch/i386/kernel/sysenter.c	Fri Apr 06 14:27:31 2007 -0700
> @@ -254,7 +254,7 @@ int arch_setup_additional_pages(struct l
>  {
>  	struct mm_struct *mm = current->mm;
>  	unsigned long addr;
> -	int ret;
> +	int ret = 0;
>  	bool compat;
>  
>  	down_write(&mm->mmap_sem);
> -

Hm, OK, but what about just zeroing it in the compat leg of the if()?

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/