Re: [PATCH 28/90] ARM: OMAP: USB peripheral support on H4

[Pavel Machek <pavel@ucw.cz>]

Hi!

> From: David Brownell <dbrownell@users.sourceforge.net>
> 
> H4 has two peripheral ports, one for "download" and one for OTG.
> The one to use is selected through Kconfig.
> 
> NOTE:  not yet working; I suspect there's a clock still turned off
> or something like that, since neither port responds.

Hmm, it would be nice to merge this with patch that makes it
working... for easier review.

But it is new code, so maybe it can just go in....

> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

> +#else
> +	/* S1.10 OFF -- usb "download port"
> +	 * usb0 switched to Mini-B port and isp1105 transceiver;
> +	 * S2.POS3 = ON, S2.POS4 = OFF ... to enable battery charging
> +	 */
> +	.register_dev	= 1,
> +	.pins[0]	= 3,
> +//	.hmc_mode	= 0x14,	/* 0:dev 1:host 2:disable */
> +	.hmc_mode	= 0x00,	/* 0:dev|otg 1:disable 2:disable */

No c++ comments, please... but I somehow suspect this one is fixed
later in series.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/