On Fri, 2007-04-06 at 12:22 -0700, Andrew Morton wrote:
> Yeah. I tried something like this and code broke. For example,
> arch/mips/sni/irq.c has
>
> struct irqaction sni_isa_irq = {
> .handler = sni_isa_irq_handler,
> .name = "ISA",
> .flags = SA_SHIRQ
> };
Grr. I fixed that one at least once.
> there are presumably only a few such stragglers left in the tree but there
> are probably more instances out-of-tree.
>
> But I think we should just apply your patch anyway. Only a small
> proportion of things will break and we do need to be rid of the old
> definitions one day.
For above use cases there is no way of emiting a deprecation warning.
OTOH it leads the user directly to the place, where he can find the fix.
Removing them completely might leave folks clueless.
> It would be great if someone could do another pass across the tree,
> clean up the remaining SA_* usages.
The above seems the only one in Linus tree. I check -mm as well.
tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
