Re: [RFC][PATCH][3/4] Add reclaim support

[Balbir Singh <balbir@in.ibm.com>]

KAMEZAWA Hiroyuki wrote:
> On Mon, 19 Feb 2007 12:20:42 +0530
> Balbir Singh <balbir@in.ibm.com> wrote:
>
> > +int memctlr_mm_overlimit(struct mm_struct *mm, void *sc_cont)
> > +{
> > +	struct container *cont;
> > +	struct memctlr *mem;
> > +	long usage, limit;
> > +	int ret = 1;
> > +
> > +	if (!sc_cont)
> > +		goto out;
> > +
> > +	read_lock(&mm->container_lock);
> > +	cont = mm->container;
>
> > +out:
> > +	read_unlock(&mm->container_lock);
> > +	return ret;
> > +}
> > +
>
> should be
> ==
> out_and_unlock:
> 	read_unlock(&mm->container_lock);
> out_:
> 	return ret;


Thanks, that's a much convention!

> -Kame


--
	Warm Regards,
	Balbir Singh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/