Re: e2b2rom_init_one(): Unable to register resource

[Cyrill Gorcunov <gorcunov@gmail.com>]

On Sun, Feb 18, 2007 at 01:29:03PM +0200, Dan Aloni wrote:
| On Sun, Feb 18, 2007 at 01:42:22PM +0300, Cyrill Gorcunov wrote:
| > Hi,
| > 
| > here is a patch attached to the mail. You may test it. Actually
| > I have no 64bit machine to test it and I'm worried about the
| > patch accuracy. So be carefull testing it. I sent a copy of the
| > message to Andi Kleen (who is a maintainer of X86-64 port) may be
| > we should wait for its answer ;)
| 
| Thanks, I'll give it a try soon.
| 
| BTW, wouldn't it be better just to change the type of phys and size
| to u32?
| 
| > diff --git a/drivers/mtd/maps/esb2rom.c b/drivers/mtd/maps/esb2rom.c
| > index a9d808a..d63c060 100644
| > --- a/drivers/mtd/maps/esb2rom.c
| > +++ b/drivers/mtd/maps/esb2rom.c
| > @@ -214,6 +214,9 @@ static int __devinit esb2rom_init_one(struct pci_dev *pdev,
| >  
| >  	/* reserved  0x0020 and 0x0010 */
| >  	window->phys -= 0x400000UL;
| > +#ifdef CONFIG_64BIT
| > +	window->phys &= 0xffffffffUL;
| > +#endif
| >  	window->size = (0xffffffffUL - window->phys) + 1UL;
| >  
| >  	/* Enable writes through the rom window */
| 
| 
| -- 
| Dan Aloni
| XIV LTD, http://www.xivstorage.com
| da-x (at) monatomic.org, dan (at) xiv.co.il
| 

Hi,

actually - I don't know... I think this could be done
by kernel developer specialist only (as Andi Kleen is).
So lets wait until his answer ;) Nevertheless, write
me if the patch resolve the problem.

-- 

		Cyrill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/