On Sat, Feb 17, 2007 at 02:59:39AM +0300, Oleg Nesterov wrote: > In that case (all processes are frozen when workqueue_cpu_callback() > calls cleanup_workqueue_thread()) I agree, it is better to just use > kthread_stop/kthread_should_stop. Great, thanks! > This also means that probably it won't be convenient to do this change > "by small steps" as I suggested before. Yeah, thats what I thought. We will try to split it to the extent possible in the next iteration. Thanks for your feedback/review! -- Regards, vatsa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- From: Oleg Nesterov <[email protected]>
- Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- References:
- [RFC PATCH(Experimental) 0/4] Freezer based Cpu-hotplug
- From: Gautham R Shenoy <[email protected]>
- [RFC PATCH(Experimental) 1/4] freezer-cpu-hotplug core
- From: Gautham R Shenoy <[email protected]>
- [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- From: Gautham R Shenoy <[email protected]>
- Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- From: Oleg Nesterov <[email protected]>
- Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- From: Srivatsa Vaddagiri <[email protected]>
- Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- From: Oleg Nesterov <[email protected]>
- Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- From: Srivatsa Vaddagiri <[email protected]>
- Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- From: Oleg Nesterov <[email protected]>
- [RFC PATCH(Experimental) 0/4] Freezer based Cpu-hotplug
- Prev by Date: Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters
- Next by Date: Re: [RFC PATCH(Experimental) 1/4] freezer-cpu-hotplug core
- Previous by thread: Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- Next by thread: Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c
- Index(es):