Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 15 Feb 2007 19:55:29 -0500
Andres Salomon <dilinger@debian.org> wrote:

> Andrew Morton wrote:
> > On Thu, 15 Feb 2007 05:08:21 -0500
> > Andres Salomon <dilinger@debian.org> wrote:
> > 
> >> Initial framework for disabling PS/2 protocol extensions.  The current
> >> protocols can only be disabled if CONFIG_EMBEDDED is selected.  No
> >> source files are changed, merely build stuff.
> > 
> > ugleee.  What benefit do we get for all this additional maintenance burden?
> 
> On any platform where you know exactly what ps/2 device you'll have
> plugged in, you can cut the size of psmouse.ko in half by disabling
> protocol extensions that are not in use.

hm, saving 4k or so.

Oh well, let's leave that up to Dmitry.

> For future protocol extension additions, we can add them without making
> the psmouse driver even larger.  We have one queued up for OLPC's
> touchpad which we'd like to get included in mainline, and it was made
> clear that being able to disable protocol extensions was a prerequisite
> for getting it included.  The OLPC ps/2 protocol extension would be
> disabled unless CONFIG_EMBEDDED and CONFIG_MOUSE_PS2_OLPC were both enabled.
> 
> See http://lkml.org/lkml/2006/9/11/200

Perhaps a nicer implementation would be to have a separate .c file for each
variant.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/