Re: [patch 14/14] syslets: x86: optimized sys_umem_add()

[Alexey Dobriyan <adobriyan@gmail.com>]

On Thu, Feb 15, 2007 at 05:52:59PM +0100, Ingo Molnar wrote:
> provide an optimized assembly version of sys_umem_add().

> --- linux.orig/arch/i386/lib/getuser.S
> +++ linux/arch/i386/lib/getuser.S

> +sys_umem_add:
> +	movl 0x4(%esp), %ecx			# uptr
> +	movl 0x8(%esp), %edx			# inc
> +
> +	cmpl $__PAGE_OFFSET, %ecx		# access_ok(uptr)
> +	jae bad_sys_umem_add
> +
> +1:	addl %edx, (%ecx)			# *uptr += inc
> +2:	movl (%ecx), %eax			# return *uptr
> +	ret
> +
> +bad_sys_umem_add:
> +	movl $-14, %eax

We have EFAULT for this. ;-)

> +	ret
> +
> +.section __ex_table,"a"
> +	.long 1b, bad_sys_umem_add
> +	.long 2b, bad_sys_umem_add
> +.previous

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/