Re: [patch] net, 8139too.c: fix netpoll deadlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Let me resume two months old topic...

On Wed, 13 Dec 2006 02:12:31 +0100, Ingo Molnar <[email protected]> wrote:
> > I have lived with the "NAPI ->poll() handler runs in BH irq enabled 
> > context" rule for years. Is it definitely false/dead ?
> > 
> > If so at least 8139cp needs the same fix.
> 
> hm, this isnt really about NAPI polling, but about the 
> netconsole/netpoll/netdump poll_controller() handler.
> 
> with netconsole, printk can be called from IRQ context (and is 
> frequently from IRQ context during bootup or module initialization), so 
> a BH rule isnt enough for them.

I see NAPI poll routine might be called with interrupt disabled.

Many (all?) NAPI drivers call netif_receive_skb() from its poll
routine (as described in NAPI-HOWTO.txt), but I thought
netif_receive_skb() cannot be called from irq context or irq disabled.
So it seems the problem is not solved completely.  Or am I missing
something?

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux