Re: [PATCH 7/8] lguest: trivial guest block driver

[Jens Axboe <jens.axboe@oracle.com>]

On Tue, Feb 13 2007, Rusty Russell wrote:
> On Mon, 2007-02-12 at 16:01 +0100, Jens Axboe wrote:
> > On Mon, Feb 12 2007, Rusty Russell wrote:
> > > Thanks Jens!!
> > 
> > My pleasure, it's not often you get to make that big a performance
> > improvement with just a little few lines of change :-)
> 
> *cough* I deliberately leave these low hanging fruit in lguest to
> encourage people to hack on it.  Really.  *cough*

:-)

> > I guess you'll take changes to make this driver queuing as well? It's
> > pretty important for good guest io performance as well.
> 
> The question is whether the guest or host should queue.  If you have
> multiple guests sharing a disk in the hose, I would think that the host
> is better off queuing.  And this would seem to be the common case.

You want queuing in the host, since for queuing to make a performance
difference it needs to be propagated all the way down to the device. But
you can't get queuing at the host level if the guest device doesn't
allow it, you'd be serializing anyway. Well for writes you can, but not
synchronous requests.

Basically allow as much to be sent to the host as possible.

> On my todo list is:
> 1) Implement write barriers, (-> fsync in the host)
> 2) Make the host userspace program (lguest) async rather than blocking,
> 3) Allow multiple outstanding requests.
> 
> Then it should be useful for other hypervisors.

I completely agree with your prioritized list.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/