From: Randy Dunlap <[email protected]> setcc() in math-emu is written as a gcc extension statement expression macro that returns a value. However, it's not used that way and it's not needed like that, so just make it a do-while non-extension macro so that we don't use an extension when it's not needed. Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Andi Kleen <[email protected]> Cc: Andi Kleen <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Segher Boessenkool <[email protected]> Signed-off-by: Andrew Morton <[email protected]> --- arch/i386/math-emu/status_w.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: linux/arch/i386/math-emu/status_w.h =================================================================== --- linux.orig/arch/i386/math-emu/status_w.h +++ linux/arch/i386/math-emu/status_w.h @@ -48,9 +48,11 @@ #define status_word() \ ((partial_status & ~SW_Top & 0xffff) | ((top << SW_Top_Shift) & SW_Top)) -#define setcc(cc) ({ \ - partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \ - partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); }) +static inline void setcc(int cc) +{ + partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); + partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); +} #ifdef PECULIAR_486 /* Default, this conveys no information, but an 80486 does it. */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension
- From: Arnd Bergmann <[email protected]>
- Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension
- From: "Jochen Voß" <[email protected]>
- [PATCH x86 for review III] [12/29] x86_64: 32-bit ptrace mangles sixth system call argument
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [13/29] i386: geode configuration fixes
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [16/29] i386: Remove fastcall in paravirt.[ch]
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [6/29] i386: Remove unused kernel config option X86_XADD
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [15/29] x86_64: Fix wrong gcc check in bitops.h
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [10/29] i386: don't include bugs.h
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [4/29] x86_64: clean up sparsemem memory_present call
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [2/29] i386: support Classic MediaGXm
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [9/29] x86_64: Minor patch for compilation warning in x86_64 signal code
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [3/29] i386: entry.S END/ENDPROC annotations
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [11/29] i386: add option to show more code in oops reports
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [19/29] x86: Enable NMI watchdog for AMD Family 0x10 CPUs
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [17/29] x86: Add new CPUID bits for AMD Family 10 CPUs in /proc/cpuinfo
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [29/29] x86: Unify pcspeaker platform device code between i386/x86-64
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [26/29] i386: Move mce_disabled to asm/mce.h
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [28/29] i386: Remove extern declaration from mm/discontig.c, put in header.
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [25/29] i386: paravirt unhandled fallthrough
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [23/29] x86: Don't require the vDSO for handling a.out signals
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [7/29] x86_64: update IO-APIC dest field to 8-bit for xAPIC
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [21/29] i386: Fix warning in cpu initialization
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [20/29] i386: Fix warning in microcode.c
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [18/29] i386: Add L3 cache support to AMD CPUID4 emulation
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [24/29] x86_64: -mm merge plans for 2.6.21
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [27/29] i386: Rename cpu_gdt_descr and remove extern declaration from smpboot.c
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [8/29] x86_64: avoid warning message livelock
- From: Andi Kleen <[email protected]>
- [PATCH x86 for review III] [5/29] i386: arch/i386/kernel/alternative.c should #include <asm/bugs.h>
- From: Andi Kleen <[email protected]>
- Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension
- Prev by Date: [PATCH x86 for review III] [16/29] i386: Remove fastcall in paravirt.[ch]
- Next by Date: [PATCH x86 for review III] [13/29] i386: geode configuration fixes
- Previous by thread: Problem with 2.6.20 based kernels on SUSE 9.3
- Next by thread: [PATCH x86 for review III] [5/29] i386: arch/i386/kernel/alternative.c should #include <asm/bugs.h>
- Index(es):