Re: unfixed regression in 2.6.20-rc6 (since 2.6.19)

[Greg KH <greg@kroah.com>]

On Mon, Feb 12, 2007 at 03:30:22PM +0100, Rainer Weikusat wrote:
> Greg KH <greg@kroah.com> writes:
> > On Tue, Jan 30, 2007 at 06:40:10PM +0100, Rainer Weikusat wrote:
> >> Greg KH <greg@kroah.com> writes:
> >> 
> >> [...]
> >> 
> >> > Rainer's problem is a real bug in the USB driver code, which we need to
> >> > work on getting fixed,
> >
> > Ok, here's an updated version, that should tell us where things are
> > going wrong (if they are.)
> >
> > Can you try this out with debugging enabled for the driver:
> > 	modprobe keyspan debug=1
> >
> > and let me know what the output of the kernel log is when you plug your
> > device in?
> 
> I can do all sorts of things, but frankly, I just need my device to
> work (which it does again, courtesy of myself). Apart from that, this
> is still just what a SCO-person would call 'a structural copy' of my
> code with no functional changes, especially none that could result in
> any additional output. I believe it will work as well. Mine does, so
> I am not going to test a different one for the sake of having done so.

Well, as others have reported that this fix works for them, I've sent it
on to Linus and will add it to the 2.6.20-stable tree too.

> If you want to fix it only if you can claim to have written the code,
> fine. If you'll never fix it --- fine as well.

I do not claim I have rewritten the code, if you look, you get full
authorship credit for this fix, I just say I restructured it a bit.

> In either case, I have already put more time into this as I have
> available.

If you still have problems, please let me know.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/