Re: [PATCH 2/3] cxacru: Poll for device status more frequently.

[Simon Arlott <simon@arlott.org>]

On 31/01/07 18:15, Duncan Sands wrote:
>> I've had it polling every 200ms on a dual ppro200 since november,
>> and it has never failed to poll the status. 
> 
> Great, that's certainly better than the speedtouch ;)
> I can't help feeling that polling twice a second is overkill.
> How about changing it to poll every 5 seconds if the line is
> up, and ten times as fast (as in this patch) if the line is
> down?  Also, what is the point of polling fast?  Does it matter
> if you miss some down-try_to_activate transitions?

It needs to be at most 2 seconds while down or it's going to miss some of the state changes, why bother to output all the types of state if you're going to ignore some of them?

As for while it's up, polling more often has a negligible effect on performance (still polling every 200ms here). If you change the timing for different states, you should know that it won't go into the down state on a retrain so ~up should enable faster polling.

-- 
Simon Arlott

Attachment: signature.asc
Description: OpenPGP digital signature