Kbuild refactoring (Re: The who needs reviews anyways [PATCH])

On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote:
[]
> - printf has other side effects, instead stop pretending we support 
>   something else than bash

Yes. With `%' in option strings there will be side effects.
I would suggest to use

    printf %s "$(1)"

with "paranoia mode on", and hope to do not forcing `bash'.

> - proper quoting
> - proper indentation
> 
> bye, Roman

Thanks.

____
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- The who needs reviews anyways [PATCH]
  - From: Roman Zippel <[email protected]>

Prev by Date: [PATCH 1/5] sysctl: Remove declaration of nonexistent sysctl_init()
Next by Date: [PATCH 2/5] sysctl: Set the parent field in the root sysctl table
Previous by thread: Re: The who needs reviews anyways [PATCH]
Next by thread: Re: The who needs reviews anyways [PATCH]
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]