Re: [PATCH 2/3] X.25: Adds /proc/sys/net/x25/x25_forward to control forwarding.

[Alexey Dobriyan <adobriyan@gmail.com>]

On Thu, Feb 08, 2007 at 11:19:09PM +0300, Alexey Dobriyan wrote:
> On Thu, Feb 08, 2007 at 10:14:31AM +1100, ahendry wrote:
> > echo "1" > /proc/sys/net/x25/x25_forward
> > To turn on x25_forwarding, defaults to off
> 
> > --- linux-2.6.20-vanilla/include/linux/sysctl.h
> > +++ linux-2.6.20/include/linux/sysctl.h
> > @@ -699,7 +699,8 @@ enum {
> >  	NET_X25_CALL_REQUEST_TIMEOUT=2,
> >  	NET_X25_RESET_REQUEST_TIMEOUT=3,
> >  	NET_X25_CLEAR_REQUEST_TIMEOUT=4,
> > -	NET_X25_ACK_HOLD_BACK_TIMEOUT=5
> > +	NET_X25_ACK_HOLD_BACK_TIMEOUT=5,
> > +	NET_X25_FORWARD=6
> >  };
> 
> > --- linux-2.6.20-vanilla/net/x25/sysctl_net_x25.c
> > +++ linux-2.6.20/net/x25/sysctl_net_x25.c
> > @@ -73,6 +73,14 @@ static struct ctl_table x25_table[] = {
> >  		.extra1 =	&min_timer,
> >  		.extra2 =	&max_timer,
> >  	},
> > +	{
> > +		.ctl_name =	NET_X25_FORWARD,
> > +		.procname =	"x25_forward",
> > +		.data = 	&sysctl_x25_forward,
> > +		.maxlen = 	sizeof(int),
> > +		.mode = 	0644,
> > +		.proc_handler = &proc_dointvec,
> > +	},
> 
> Reserving binary sysctl number and not defining ->strategy is strange.

Ouch, please, ignore. I misparsed sysctl code.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/