Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing

On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
> I suspect all this horror is due to stupidity in the DMA API.
> 
> pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas
> the caller (megasas_mgmt_fw_ioctl) would have been perfectly happy
> to use GFP_KERNEL.
> 
> I bet this fixes it

It does, but the DMA API was expanded to cope with this exact case, so
use dma_alloc_coherent() directly in the megaraid code instead.  The dev
is just &pci_dev->dev.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing
  - From: Sumant Patro <[email protected]>
- Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing
  - From: Andrew Morton <[email protected]>

Prev by Date: Re: [PATCH 2/2] sysctl: Restore the selinux path based label lookup for sysctls.
Next by Date: Re: mm snapshot broken-out-2007-02-06-16-59.tar.gz uploaded
Previous by thread: Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing
Next by thread: Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctl processing
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]