Re: SATA hotplug from the user side ?

[Tejun Heo <htejun@gmail.com>]

Eric D. Mudama wrote:
> In the ATA spec, the CHECK POWER MODE command (E5h) specifically
> states that it shouldn't alter the power mode of the device.
> Therefore, there should be no harm in checking the power mode of a
> device in STANDBY or IDLE state, and it shouldn't cause the device to
> spin up.  Checking a drive on my bench I confirmed this behavior.

Yes, we can but...

1. As I wrote in the other reply, I don't think that's necessary.
Devices don't spin up on FLUSH_CACHE followed by STANDBY_IMMEDIATE when
they are in Standby state. (Please point out if this isn't true on most
drives)

2. As the code currently stands, we have to rely on SCSI HLD for
shutting down.  We can query power state there and issue shutdown
conditionally and all those will be properly translated by libata but
it's a bit complex.  I'm not sure whether the added complexity is justified.

> With Serial ATA you have to consider the SATA bus PM states as well,
> but that's a different topic of discussion.

I think that can be dealt with separately.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/