Re: [PATCH] atl1_main: pci_module_int returns to haunt us

[Jay Cliburn <jacliburn@bellsouth.net>]

Alan wrote:
> Perhaps Adrian would care to simply delete the pci_module_init ancient compat
> code so nobody else can inadvertently merge a driver that uses it.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c
> --- linux.vanilla-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c	2007-01-31 14:20:41.000000000 +0000
> +++ linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c	2007-01-31 15:25:29.083361224 +0000
> @@ -2482,12 +2482,9 @@
>   **/
>  static int __init atl1_init_module(void)
>  {
> -	int ret;
>  	printk(KERN_INFO "%s - version %s\n", atl1_driver_string, DRIVER_VERSION);
>  	printk(KERN_INFO "%s\n", atl1_copyright);
> -	ret = pci_module_init(&atl1_driver);
> -
> -	return ret;
> +	return pci_register_driver(&atl1_driver);
>  }
>  
>  module_init(atl1_init_module);

Ack.  As expected, works fine.  Thanks.

Jay

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/