Re: [PATCH 08/23] clocksource: drop duplicate register checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Daniel Walker <[email protected]> wrote:

> >          if (is_registered_source(c)) {
> >                  printk("register_clocksource: Cannot register %s. "
> >                         "Already registered!", c->name);
> >                  ret = -EBUSY;
> > 
> > and Thomas' change keeps that property, but doesnt printk. Your 
> > change makes double registry possible, potentially crashing the 
> > kernel later on! (And this isnt theoretical, double registry did 
> > happen in practice when i debugged suspend problems on my SMP 
> > laptop.)
> 
> My original patch set makes the duplicate register checking better 
> (which I dropped) .. I'll be happy to reintroduce that part of it..

why if Thomas' patch: simplify-the-registration-of-clocksources.patch 
already does it?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux