Re: [PATCH] pipefs unique inode numbers

[Kirill Korotaev <dev@sw.ru>]

Linus,

>>Also, that patch would break many 32-bit programs not compiled with large
>>offsets when run in compatibility mode on a 64-bit kernel. If they were to
>>do a stat on this inode, it would likely generate an EOVERFLOW error since
>>the pointer address would probably not fit in a 32 bit field.
>>
>>That problem was the whole impetus for this set of patches.
> 
> 
> Well, we have that problem with the slowly incrementing "last_ino" too.
> 
> Should we make "last_ino" be "static unsigned int" instead of "long"?
yes. it is what the 1st patch (AFAIK commited to -mm) from Jeff.

> Does anybody actually even use the old stat() with 32-bit interfaces? We 
> warn for it, and we've done so for a long time.. I dont' remember people 
> even complaining about the warning, so..
Yes, we saw this happening multiple times already.
e.g. many OpenVZ users run 32bit VEs on 64bit host OS.
due to this bug some apps (e.g. postfix) complain about EOVERFLOW returned by stat()
and fail to work.
I also observed similar bug on Debian 3.0 which has 'find' compiled w/o FILE_OFFSETS=64,
but NFS partition used 64bit inode numbers.

Thanks,
Kirill
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/