Re: [PATCH 2/8] Create the ZONE_MOVABLE zone

[Mel Gorman <mel@csn.ul.ie>]

On Fri, 26 Jan 2007, Christoph Lameter wrote:

> On Thu, 25 Jan 2007, Mel Gorman wrote:
>
> > @@ -166,6 +168,8 @@ enum zone_type {
> >  #define ZONES_SHIFT 1
> >  #elif __ZONE_COUNT <= 4
> >  #define ZONES_SHIFT 2
> > +#elif __ZONE_COUNT <= 8
> > +#define ZONES_SHIFT 3
> >  #else
>
> You do not need a shift of 3. Even with ZONE_MOVABLE the maximum
> number of zones is still 4.

Yep, this is correct. If it's ever wrong, there is an additional check for 
__ZONE_COUNT that will print out the appropriate warning.

Thanks

--
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/