Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: David Brownell <[email protected]>
> Date: Fri, 26 Jan 2007 20:21:54 -0800

> In fact, how about this one instead?  It uses a bit in spi->mode
> since that's pretty easy to test.  And while it doesn't get rid
> of the multiple conditionals when the tx buffer is null, it does
> let the other values be constants (0, ~0) that compilers like.

I'm fine, except the typo.

> (I can update your patch #4, etc, to match.)

Or I could, and test it to boot. :)

> +#define MODEBITS	(SPI_CPHA | SPI_CPOL | SPI_CS_HIGH | SPI_TX_1)

Add SPI_LSB_FIRST (still supported by spi_bitbang, I presume :)

brgds, H-P
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux