Re: [RFC] cycle timer read extension for raw1394/libraw1394

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Pieter Palmers wrote:
> Stefan Richter wrote:
>> Thus?
>>     preempt_disable();
>>     local_irq_save(flags);
>>
>>     read_cycle_timer;
>>     read_time_of_day;
>>
>>     local_irq_restore(flags);
>>     preempt_enable();
>>
>> in hpsb_read_cycle_timer.
> My main issue was that I still had to figure out how to do this... I'm a
>  very occasional kernel space programmer.

Unfortunately me too, and the level of ieee1394 driver maintenance shows it.

> Thanks for the hint, I'll do it like this.
> 
> I still have to check if I don't introduce a too long non-preemptible
> path though.

It's a simple MMIO read (readl) and the do_gettimeofday, which should be
fine.
-- 
Stefan Richter
-=====-=-=== ---= ==-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/