Re: + dynamic-kernel-command-line-sparc64-fix.patch added to -mm tree

["Alon Bar-Lev" <alon.barlev@gmail.com>]

On 1/27/07, akpm@osdl.org <akpm@osdl.org> wrote:
> diff -puN drivers/sbus/char/openprom.c~dynamic-kernel-command-line-sparc64-fix drivers/sbus/char/openprom.c
> --- a/drivers/sbus/char/openprom.c~dynamic-kernel-command-line-sparc64-fix
> +++ a/drivers/sbus/char/openprom.c
> @@ -283,7 +283,7 @@ static int oprompath2node(void __user *a
>
>  static int opromgetbootargs(void __user *argp, struct openpromio *op, int bufsize)
>  {
> -       char *buf = saved_command_line;
> +       char *buf = boot_command_line;
>         int len = strlen(buf);
>
>         if (len > bufsize)

Hello Andrew,

I don't think this is correct.
The boot_command_line should only be used by init code.
Drivers should continue to use saved_command_line.

I don't know why saved_command_line cannot be resolved and
boot_command_line can be.
They are both located in linux/init.h

extern char __initdata boot_command_line[];
extern char *saved_command_line;

And the drivers/sbus/char/openprom.c do include it and I assume
__ASSEMBLY__ is not defined.

Best Regards,
Alon Bar-Lev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/