Re: [PATCH] videobuf_qbuf: fix? possible videobuf_queue->stream corruption and lockup

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Em Ter, 2007-01-23 às 20:57 +0300, Oleg Nesterov escreveu:
> I am pretty sure the bug is real, but the patch may be wrong, please review.
> 
> We are doing ->buf_prepare(buf) before adding buf to q->stream list. This
> means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer.
> 
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

Chris/Adrian,

IMO, this should also be applied at -stable trees.
> 
> --- 6.19/drivers/media/video/video-buf.c~v4l_lockup	2006-11-17 19:42:25.000000000 +0300
> +++ 6.19/drivers/media/video/video-buf.c	2007-01-23 19:44:19.000000000 +0300
> @@ -700,6 +700,7 @@ videobuf_qbuf(struct videobuf_queue *q,
>  		goto done;
>  	}
>  	if (buf->state == STATE_QUEUED ||
> +	    buf->state == STATE_PREPARED ||
>  	    buf->state == STATE_ACTIVE) {
>  		dprintk(1,"qbuf: buffer is already queued or active.\n");
>  		goto done;
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/