Re: [PATCH 2.6.20-rc5 4/4] sys_futex64 : allows 64bit futexes

[Christoph Hellwig <hch@infradead.org>]

On Thu, Jan 18, 2007 at 08:45:56AM +0100, Ingo Molnar wrote:
> include/asm-i386/futex.h:
> 
>                 switch (cmp) {
>                 case FUTEX_OP_CMP_EQ: ret = (oldval == cmparg); break;
>                 case FUTEX_OP_CMP_NE: ret = (oldval != cmparg); break;
>                 case FUTEX_OP_CMP_LT: ret = (oldval < cmparg); break;
>                 case FUTEX_OP_CMP_GE: ret = (oldval >= cmparg); break;
>                 case FUTEX_OP_CMP_LE: ret = (oldval <= cmparg); break;
>                 case FUTEX_OP_CMP_GT: ret = (oldval > cmparg); break;
>                 default: ret = -ENOSYS;
>                 }
> 
> Pierre correctly matched the existing style.

Old code doing things wrong is no excuse for new code doing the same
mistake.  Much better send a patch to fix up the previous unreadable
mess aswell.  Then again some indentation fixups won't help that much
to make futrsx not the totally unreadable spaghetti code it's now ;-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/