On Mon, Jan 15, 2007 at 02:54:10AM +0300, Oleg Nesterov wrote: > How about the pseudo-code below? Some quick comments: - singlethread_cpu needs to be hotplug safe (broken currently) - Any reason why cpu_populated_map is not modified on CPU_DEAD? - I feel more comfortable if workqueue_cpu_callback were to take workqueue_mutex in LOCK_ACQ and release it in LOCK_RELEASE notifications. This will provide stable access to cpu_populated_map to functions like __create_workqueue. Finally, I wonder if these changes will be unnecessary if we move to process freezer based hotplug locking ... -- Regards, vatsa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Oleg Nesterov <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- References:
- [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Oleg Nesterov <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Andrew Morton <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Srivatsa Vaddagiri <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Andrew Morton <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Oleg Nesterov <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Srivatsa Vaddagiri <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Oleg Nesterov <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Srivatsa Vaddagiri <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Oleg Nesterov <[email protected]>
- Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- From: Oleg Nesterov <[email protected]>
- [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- Prev by Date: Re: ahci_softreset prevents acpi_power_off
- Next by Date: Re: allocation failed: out of vmalloc space error treating and VIDEO1394 IOC LISTEN CHANNEL ioctl failed problem
- Previous by thread: Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- Next by thread: Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
- Index(es):
 |