Re: it821x trouble since 2.6.18

[Alan <alan@lxorguk.ukuu.org.uk>]

> 2. Trying to understand what has happened I found the main difference
> is not in the driver but in ide-dma.c:
> 
> --- linux-2.6.17.14/drivers/ide/ide-dma.c   2006-06-18 01:49:35.000000000 +0000
> +++ linux-2.6.18.6/drivers/ide/ide-dma.c    2006-09-20 03:42:06.000000000 +0000
> @@ -752,7 +750,7 @@
>                         goto bug_dma_off;
>                 printk(", DMA");
>         } else if (id->field_valid & 1) {
> -               printk(", BUG");
> +               goto bug_dma_off;
>         }
>         return;
>  bug_dma_off:
> 
> 
> and reverting that change returns the old transfer rates. But that is
> probably not a good idea.

It should be just fine. 

> So I tried this again:

This is complete bogus. You simply poked random incorrect registers and
happened not to crash the chip, or confuse it, and since you have the
IT821x bios enabled it happened to have roughly valid configuration.

> and disabled CONFIG_BLK_DEV_IT821X - and now the disk is even faster
> than before:

For all the wrong reasons I would add.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/