> > spin_lock_irqsave(&ehca_cq_idr_lock, flags); > > while (my_cq->nr_callbacks) > > yield(); > Isn't that code outright buggy? Calling into the scheduler with a > spinlock held and local interrupts disabled... Yes, absolutely -- if nr_callbacks is ever nonzero then this will obviously crash instantly. - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()
- From: Hoang-Nam Nguyen <[email protected]>
- Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()
- References:
- [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()
- From: Hoang-Nam Nguyen <[email protected]>
- Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()
- From: Christoph Hellwig <[email protected]>
- Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()
- From: Nathan Lynch <[email protected]>
- [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()
- Prev by Date: Re: [PATCH/RFC 2.6.21 2/5] ehca: ehca_uverbs.c: "proper" use of mmap
- Next by Date: Need help with PCI-E interrupts
- Previous by thread: Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()
- Next by thread: Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()
- Index(es):
 |