Re: [PATCH] mm: pagefault_{disable,enable}()

[Linus Torvalds <torvalds@osdl.org>]

On Wed, 10 Jan 2007, Geert Uytterhoeven wrote:
> 
> This change causes lots of compile errors of the following form on m68k:
> 
> | linux-2.6.20-rc4/include/linux/uaccess.h: In function `pagefault_disable':
> | linux-2.6.20-rc4/include/linux/uaccess.h:18: error: dereferencing pointer to incomplete type
> | linux-2.6.20-rc4/include/linux/uaccess.h: In function `pagefault_enable':
> | linux-2.6.20-rc4/include/linux/uaccess.h:33: error: dereferencing pointer to incomplete type

Ouch. However, I think your patch is bogus.

You're fixing somethign that doesn't need fixing: <linux/uaccess.h> 
already includes <linux/preempt.h> for the preemption functions.

The REAL problem seems to be that the m68k preempt.h (or rather, to be 
exact, asm/thread_info.h) doesn't do things right, and while it exposes 
"inc_preempt_count()", it doesn't expose enough information to actually 
use it.

I think your "current_thread_info()" is broken.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/