Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

[Linus Torvalds <torvalds@osdl.org>]

On Mon, 8 Jan 2007, Adrian Bunk wrote:
> 
> We just got a completely different bug reported that was confirmed to be 
> caused by Andi's patch:
>    AMD64/ATI : timer is running twice as fast as it should [1]

Yeah. I have to say, that with my main goal for 2.6.20 being a stability 
release, and the APIC setup scaring me too, I'm starting to strongly lean 
towards just reverting the thing, and then having this whole thing 
re-introduced early during the 2.6.21 cycle with the new information we 
have (ie the clues about exactly why the dang thing broke in the first 
place).

After all, the only reason I didn't want to revert the commit initially 
was that it did clean things up, and I wanted to understand why it didn't 
work. I think we understand why it caused problems, and I think we can fix 
them, but on the other hand, we're already deep into -rc4 with this, so 
let's just revert for now and then clean it up correctly after the 2.6.20 
release.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/