Re: [PATCH] sata_via: PATA support, resubmit

[Alan <alan@lxorguk.ukuu.org.uk>]

> The problem you need to fix or work around is ata_probe_ent, which 
> doesn't properly fill in ata_port info for this situation.  Tejun has 
> posted patches that kill ata_probe_ent, which you were pointed to. 

And which are not yet in the main tree leaving many users unable to
install Linux. This isn't the way to get stuff done. When you've got the
new patches in the driver can use them if its worth it (which, see below,
I question).

> If you get the setup right, you don't bloat each hook with "is this port 
> PATA?" tests.  At present, your sata_via patch introduces these needless 
> tests.

Which I might note are actually smaller than the extra structs and on a
code path usually executed twice per boot. So the needless tests are more
efficient and not on a hot path and are shorter than the elegant
not-present solution and let users actually install Linux on current VIA
systems, which right now the generally cannot do.

Out of boredom I'll also note that clock timings say that if the extra
port info stuff causes a single extra L1 cache miss its also faster to do
the tests.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/