Re: 2.6.20-rc3-git4 oops on suspend: __drain_pages

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Em Dom, 2007-01-07 às 18:33 +0200, Pekka Enberg escreveu:
> On Thu, 4 Jan 2007, Robert Hancock wrote:
> > > > Saw this oops on 2.6.20-rc3-git4 when attempting to suspend. This only
> > > > happened in 1 of 3 attempts.
> 
> On Friday, 5 January 2007 20:15, Christoph Lameter wrote:
> > > See the fix that I posted yesterday to linux-mm. Its now in Andrew's tree.
> 
> On 1/5/07, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > I can't find it in -mm.
> >
> > Could you please post it here?
> 
> I think it's this:
> 
> http://marc.theaimsgroup.com/?l=linux-mm&m=116793590117896&w=2

This fixed for me too with kernel 2.6.19.1. On my machine, every second
trial to unplug the second CPU core were generating OOPS, and breaking
hibernation. I've opened a bugzilla (#7786).

There is a remain stuff to be fixed, related to cpuhotplug: kernel with
debug options enabled shows that there is a circular locking dependency
(http://bugzilla.kernel.org/attachment.cgi?id=10020&action=view):

 =======================================================
[ INFO: possible circular locking dependency detected ]
2.6.19.1 #1
-------------------------------------------------------
stress/5670 is trying to acquire lock:
 (cpu_bitmask_lock){--..}, at: [<ffffffff8015af7d>] lock_cpu_hotplug+0x6d/0x80

but task is already holding lock:
 (workqueue_mutex){--..}, at: [<ffffffff8014962f>] workqueue_cpu_callback+0x16f/0x2d0

which lock already depends on the new lock.

This happens the first time I do:

echo 0 >/sys/devices/system/cpu/cpu1/online

on an AMD/64 dual core.

It would be interesting to have this patch also applied to -stable.

Cheers, 
Mauro.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/